Conversation
ADDED: Expedition Logbooks are parsed, priced and searched — `Strategy::Logbook`, an item class the app had no reading for at all. ADDED: A destination is structure rather than modifiers — its area, its faction and its implicits are one `LogbookArea`, recognised by shape rather than by a table of factions. - The two leading lines are matched on being bare names and the tail on reading as modifiers, so the four factions and the dozens of areas stay game data. The number of implicits is not fixed: the captures show two and three. ADDED: `SearchPlan::choices` — a set of filters the search sends **one** of, drawn as a radio at the head of the filter list. - A logbook lists up to three destinations and the player travels to exactly one, so a query naming all three prices the single copy in the league that leads to that trio, and one naming none prices every logbook in the league. The alternative's own row *is* its faction filter rather than a heading over one. ADDED: The faction and the area join to their `pseudo.*` stats through two lexicon terms, the shape `SanctumEffectPrefix` already had, so no faction name is compiled in. ADDED: The area level is searched as a floor and ticked; the item level, quantity, rarity and pack size are offered unticked. - Measured on the rare capture: category, type, `map_filters.area_level` at 80 and the faction pseudo together return 983 listings, so all four are indexed for this category. The other three are not measured yet, and a filter the site accepts and indexes nothing under empties the search. ADDED: "Dannig" is a usage needle, or a logbook's usage note comes back as a modifier. ADDED: Three captures — a normal, a rare and a magic logbook — and the bundle slice they need. CHANGED: A destination's implicit is seeded as a floor with no ceiling. - Trade indexes an item's implicits as one total per stat and every destination feeds it: the rare capture's 14% and 16% Explosives are indexed as 30%, so a ceiling from one destination asks the other two not to exist. CHANGED: `merge_same_stat` never folds across a choice, as it never folds across `hidden`. CHANGED: The strategy picker offers neither reading for a logbook, as it already does for a heist item. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
CHANGED: Quantity, rarity and pack size stay unticked because a logbook is not bought for them, where they read as waiting on a measurement of whether the site indexes them. - The one place this strategy parts company with the map keys it borrows: a map is run for its quantity and pack size and ticks them, and a logbook's are a second-order bonus on top of the artifacts the destination decides. They also only exist on a magic or rare book, so ticking them would search the same logbook two ways depending on whether it had rolled affixes at all. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
ADDED: Expedition Logbooks are priced. Copy one and the panel reads it as what it is — an
expedition that can go to up to three different places, one of which you will pick.
Each destination is a line of its own: the faction whose land it is, in bold, and the area it
leads to underneath. Pick one and the search is about that destination; the others stay on screen
with where they lead, one click away. That is the whole point of it — a logbook with a valuable
faction on it is worth what that faction is worth, and asking the trade site for all three
destinations at once finds the single copy in the league that happens to lead to that exact trio.
The chosen destination brings its area and the modifiers that apply there as rows you can switch
on; neither is on by default, because a buyer choosing a faction is rarely choosing the area with
it. The area level is searched, as a floor — an 83 answers a search for an 80. The item level, and
the quantity, rarity and pack size a magic or rare book grants, are offered but left off: unlike
a map, a logbook is not run for those. The affixes it prints below its destinations sit under the
section at the foot of the list, the way a map's do — a currency re-rolls them, so they are not
what the book is bought for, but they are still one tick away when they are the question.
Review notes
ADDED: Expedition Logbooks are parsed, priced and searched —
Strategy::Logbook, an itemclass the app had no reading for at all.
ADDED: A destination is structure rather than modifiers — its area, its faction and its
implicits are one
LogbookArea, recognised by shape rather than by a table of factions.the four factions and the dozens of areas stay game data. The number of implicits is not fixed:
the captures show two and three.
ADDED:
SearchPlan::choices— a set of filters the search sends one of, drawn as a radioat the head of the filter list.
naming all three prices the single copy in the league that leads to that trio, and one naming
none prices every logbook in the league. The alternative's own row is its faction filter
rather than a heading over one — drawing it again underneath offered to untick what the radio
button had just decided.
ADDED: The faction and the area join to their
pseudo.*stats through two lexicon terms, theshape
SanctumEffectPrefixalready had, so no faction name is compiled in.ADDED: The area level is searched as a floor and ticked; the item level, quantity, rarity and
pack size are offered unticked.
map_filters.area_levelat 80 and the factionpseudo together return 983 listings, so all four are indexed for this category.
pending a measurement. It is the one place this parts company with the map keys it borrows: a
map is run for its quantity and pack size and ticks them, and a logbook's are a second-order
bonus on top of the artifacts the destination decides. They also only exist on a magic or rare
book, so ticking them would search the same logbook two ways depending on whether it had rolled
affixes at all. Nobody has measured that the site indexes them for this category either.
ADDED: "Dannig" is a usage needle, or a logbook's usage note comes back as a modifier.
ADDED: Three captures — a normal, a rare and a magic logbook — and the bundle slice they need.
CHANGED: A destination's implicit is seeded as a floor with no ceiling.
capture's 14% and 16% Explosives are indexed as 30%, so a ceiling from one destination asks the
other two not to exist.
CHANGED:
merge_same_statnever folds across a choice, as it never folds acrosshidden.CHANGED: The strategy picker offers neither reading for a logbook, as it already does for a
heist item.
Not in this change
Two of the five affixes on the rare capture resolve to nothing, and it is a data-side gap rather
than this strategy:
+#% Monster Chaos Resistanceand+#% Monster Elemental Resistancesarepublished with the sign inside the matcher, and
placeholder_formreplaces the sign along withthe digits, so nothing the clipboard prints can reach them. 34 of the bundle's 15,148 matchers are
shaped that way and it affects maps as much as logbooks. The pricing case asserts three hidden
affixes for that reason and becomes five the day it is fixed.
Split is not parsed, not filtered and not mentioned — asked for, rather than overlooked.
🤖 Generated with Claude Code